Skip to content

Conversation

prebidPinkLion
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Updated bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes

Other information

documentation PR -> prebid/prebid.github.io#6087

Copy link

github-actions bot commented Jun 5, 2025

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 9d6f7d2

pinkLion

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/pinkLion/pinkLion.go:29:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/pinkLion/pinkLion.go:36:	MakeRequests	74.2%
github.com/prebid/prebid-server/v3/adapters/pinkLion/pinkLion.go:86:	makeRequest	85.7%
github.com/prebid/prebid-server/v3/adapters/pinkLion/pinkLion.go:104:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/pinkLion/pinkLion.go:141:	getBidType	100.0%
total:									(statements)	85.9%

@SyntaxNode SyntaxNode changed the title init new pinkLion adapter New Adapter: pinkLion Jun 5, 2025
@bsardo bsardo added the adapter label Jun 5, 2025
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 5132f7a

pinklion

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/pinklion/pinklion.go:28:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/pinklion/pinklion.go:35:	MakeRequests	74.2%
github.com/prebid/prebid-server/v3/adapters/pinklion/pinklion.go:85:	makeRequest	85.7%
github.com/prebid/prebid-server/v3/adapters/pinklion/pinklion.go:103:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/pinklion/pinklion.go:140:	getBidType	100.0%
total:									(statements)	85.9%

Copy link
Contributor

@SyntaxNode SyntaxNode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have concerns over the implementation of this adapter. Thank you for starting a separate discussion.

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 5683fc3

pinklion

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/pinklion/pinklion.go:28:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/pinklion/pinklion.go:35:	MakeRequests	74.2%
github.com/prebid/prebid-server/v3/adapters/pinklion/pinklion.go:85:	makeRequest	85.7%
github.com/prebid/prebid-server/v3/adapters/pinklion/pinklion.go:103:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/pinklion/pinklion.go:140:	getBidType	100.0%
total:									(statements)	85.9%

@prebidPinkLion
Copy link
Contributor Author

@bsardo added alias

aliasOf: "teqblaze"
endpoint: "https://us-east-ep.pinklion.io/pserver"
maintainer:
email: "[email protected]"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've sent an email to this address. Please respond to the email so that we can confirm that the address is reachable.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prebidPinkLion please respond to the email I sent on 8/28.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsardo replied

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 verified receipt.

@@ -0,0 +1,15 @@
aliasOf: "teqblaze"
endpoint: "https://us-east-ep.pinklion.io/pserver"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the endpoint is reachable:

curl -i --location --request POST https://us-east-ep.pinklion.io/pserver
HTTP/1.1 204 No Content
Server: nginx/1.24.0
Date: Thu, 28 Aug 2025 18:58:58 GMT
Connection: keep-alive
Access-Control-Allow-Origin: *
Access-Control-Allow-Credentials: true

@bsardo bsardo dismissed SyntaxNode’s stale review September 4, 2025 17:05

The concern has been addressed offline.

@bsardo bsardo merged commit 689c5c8 into prebid:master Sep 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants