Skip to content

Seedtag: Adds GPP macros on user sync url#4465

Merged
bsardo merged 3 commits intoprebid:masterfrom
seedtag:LN-2995-handle-gpp-string-in-cookie-sync
Jan 20, 2026
Merged

Seedtag: Adds GPP macros on user sync url#4465
bsardo merged 3 commits intoprebid:masterfrom
seedtag:LN-2995-handle-gpp-string-in-cookie-sync

Conversation

@sangarbe
Copy link
Contributor

No description provided.

przemkaczmarek
przemkaczmarek previously approved these changes Aug 11, 2025
Copy link
Contributor

@pm-jaydeep-mohite pm-jaydeep-mohite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

userSync:
iframe:
url: "https://s.seedtag.com/cs/cookiesync/prebid?gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&usp_consent={{.USPrivacy}}&redirect={{.RedirectURL}}"
url: "https://s.seedtag.com/cs/cookiesync/prebid?gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&usp_consent={{.USPrivacy}}&gpp={{.GPP}}&gpp_sid={{.GPP_SID}}&redirect={{.RedirectURL}}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be gpp={{.GPP}}&gpp_sid={{.GPPSID}}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed @bsardo ! thanks for pointing it out

@bsardo bsardo dismissed stale reviews from pm-jaydeep-mohite and przemkaczmarek August 19, 2025 19:28

Found an issue with one of the macros that needs to be resolved first.

@bsardo
Copy link
Collaborator

bsardo commented Oct 21, 2025

@sangarbe please see above about incorrect macro.

@bsardo
Copy link
Collaborator

bsardo commented Nov 19, 2025

@sangarbe please see issue above.

@bsardo
Copy link
Collaborator

bsardo commented Jan 10, 2026

@sangarbe please address my comment above

@sangarbe
Copy link
Contributor Author

Ey @bsardo I'll make this change asap

@bsardo bsardo merged commit 16a0652 into prebid:master Jan 20, 2026
4 checks passed
mikael-lundin pushed a commit to Adnuntius/prebid-server that referenced this pull request Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants