Rules Engine Module: Dynamic ruleset from YAML geoscopes #4509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxNode
reviewed
Sep 4, 2025
| @@ -33,6 +33,7 @@ type BidderInfo struct { | |||
| ModifyingVastXmlAllowed bool `yaml:"modifyingVastXmlAllowed" mapstructure:"modifyingVastXmlAllowed"` | |||
| Debug *DebugInfo `yaml:"debug" mapstructure:"debug"` | |||
| GVLVendorID uint16 `yaml:"gvlVendorID" mapstructure:"gvlVendorID"` | |||
| Geoscope []string `yaml:"geoscope" mapstructure:"geoscope"` | |||
There was a problem hiding this comment.
Nitpick: Please add alphabetically.
| exclusion := "" | ||
| if strings.HasPrefix(code, "!") { | ||
| exclusion = "!" | ||
| code = strings.TrimPrefix(code, "!") |
There was a problem hiding this comment.
Nitpick: To remove the first character, seems more natural to use code = code[1:].
| errMsg string | ||
| }{ | ||
| { | ||
| name: "nil-geoscope", |
There was a problem hiding this comment.
Nitpick: The word "geoscope" is redundant. Consider calling this "nil" and the other "empty".
| }, | ||
| { | ||
| name: "valid-iso-codes", | ||
| geoscope: []string{"USA", "CAN", "GBR"}, |
There was a problem hiding this comment.
Why 3 codes instead of 1?
| }, | ||
| { | ||
| name: "invalid-length", | ||
| geoscope: []string{"USAA", "CAN"}, |
There was a problem hiding this comment.
Why include CAN here too?
| }, | ||
| { | ||
| name: "invalid-exclusion-length", | ||
| geoscope: []string{"USA", "!CANN"}, |
| }, | ||
| { | ||
| name: "non-letter-characters", | ||
| geoscope: []string{"US1", "CAN"}, |
There was a problem hiding this comment.
Why include CAN here? You get the idea.. :)
| "FIN", "FRA", "GBR", "GRC", "HRV", "HUN", "IRL", "ISL", "ITA", "LIE", | ||
| "LTU", "LUX", "LVA", "MLT", "NLD", "NOR", "POL", "PRT", "ROU", | ||
| "SWE", "SVN", "SVK", | ||
| }, |
There was a problem hiding this comment.
Don't we have a config for the EEA definition? EEACountries?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #4379.
Does not include the validation logic proposed in #4379 (comment) that is currently under review.