Skip to content

Conversation

@thegecko
Copy link

@thegecko thegecko commented Dec 3, 2023

Fixes #49

This PR adds support for driving cmake-js in the same way as prebuild by using the --backend flag. e.g.:

prebuildify --backend cmake-js -- --prefer-clang

@vweevers
Copy link
Member

vweevers commented Dec 3, 2023

I prefer the generic approach of #7.

@thegecko
Copy link
Author

thegecko commented Dec 3, 2023

I prefer the generic approach of #7.

AFAICT that removes all build support and instead the user needs to define their own external script command?

That approach is quite a breaking change as all users of prebuildify would need to all specify (the same) replacement build script externally. This feels opaque and not very user friendly.

If there were a lot of common build backends, I can see the benefit of that approach, but I'm not aware of anything outside of just node-gyp and cmake-js.

Another benefit of this approach is it aligns with the existing prebuild package.

@vaguue
Copy link

vaguue commented Jul 12, 2024

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cmake-js support

3 participants