Fix workflow_dispatch for tag

[BenjaminRodenberg]

• Apply tag for both jobs
• Set default if not run via workflow_dispatch

[IshaanDesai]

The default tag is nightly, so why do we need to additionally mention this now? Also, having such a tag specification is only relevant for release testing, right? Or is there some other motivation?

[BenjaminRodenberg]

The default tag is nightly, so why do we need to additionally mention this now?

What do you mean? Be aware that if a workflow is triggered by a push that this does not pick up the defaults from the workflow dispatch. Meaning: this line evaluates to precice/precice: because ${{ inputs.docker_image_tag }} is undefined.

Also, having such a tag specification is only relevant for release testing, right? Or is there some other motivation?

Yes. That's the only reason.

[IshaanDesai]

What do you mean? Be aware that if a workflow is triggered by a push that this does not pick up the defaults from the workflow dispatch.

Ah okay. I was missing this information about the function of how the default works 👍

[BenjaminRodenberg]

What do you mean? Be aware that if a workflow is triggered by a push that this does not pick up the defaults from the workflow dispatch.

Ah okay. I was missing this information about the function of how the default works 👍

It's also 100% not intuitive. If you want to convince yourself that this is not your fault: Take a look at https://github.com/orgs/community/discussions/26322 😅