Skip to content

Update to matlab-actions/setup-matlab@v2 #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 37 commits into from
Apr 3, 2025

Conversation

BenjaminRodenberg
Copy link
Member

Using v1 raises the warning:

  Warning: matlab-actions/setup-matlab@v1 is no longer supported. Update your workflow to use the most recent version of MATLAB actions.

(see https://github.com/precice/matlab-bindings/actions/runs/12908663295/job/35995500795#step:3:206)

Using v1 raises the warning:

```
  Warning: matlab-actions/setup-matlab@v1 is no longer supported. Update your workflow to use the most recent version of MATLAB actions.
```

(see https://github.com/precice/matlab-bindings/actions/runs/12908663295/job/35995500795#step:3:206)
@BenjaminRodenberg
Copy link
Member Author

Looks like there is a problem with the license. I will investigate this further.

@BenjaminRodenberg BenjaminRodenberg force-pushed the update-setupmatlab-to-v2 branch from 4072d4f to 4903de0 Compare April 2, 2025 12:44
Copy link
Member Author

@BenjaminRodenberg BenjaminRodenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I reached a state in this PR where I understand what's going on: v2 of matlab-actions/setup-matlab only allows you to run MATLAB commands using the action matlab-actions/run-command@v2. This brings us to the problem that we cannot easily start two MATLAB processes (one for each solverdummy) in parallel. As far as I know it is not possible to 1) run two scripts in parallel within MATLAB via matlab-actions/run-command or to 2) run two steps (i.e. two individual matlab-actions/run-command) of a github action in parallel.

This means that I'm unfortunately stuck here (at least if we are looking for a reasonably simple solution).

Potential complicated solution: Run two individual workflows of github actions (each responsible for one solverdummy) and connect them to each other. This is probably tricky with the routing and scheduling we would need here.

@BenjaminRodenberg
Copy link
Member Author

WIP note: I also added /usr/lib/x86_64-linux-gnu/libpython3.12.so to LD_PRELOAD due to the error /lib/x86_64-linux-gnu/libpython3.12.so.1.0: undefined symbol:.... I observed this error for R2022b, R2022a, and R2021b. It is not needed for R2024a.

@BenjaminRodenberg BenjaminRodenberg marked this pull request as ready for review April 3, 2025 09:02
Copy link
Member

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@BenjaminRodenberg BenjaminRodenberg merged commit b479c51 into develop Apr 3, 2025
2 checks passed
@BenjaminRodenberg BenjaminRodenberg deleted the update-setupmatlab-to-v2 branch April 3, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants