-
-
Notifications
You must be signed in to change notification settings - Fork 12
first basic model switching impl #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
IshaanDesai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work already! I did a first pass, in which I looked at everything except the tests. I would like to do another review before we finalize things, especially to look at the model_adaptivity.py once more. Please take a look at my comments.
| locations : np.array - shape(N,D) | ||
| Array with gaussian points for all sims. D is the mesh dimension. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about having macro locations as part of the switching function inputs. I could imagine the switching being solely based on the macro- and micro-scale data available at a particular point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it might be useful to enforce FOM at certain locations, where the user can already expect high fluctuations in input/output or where maximal accuracy should be guaranteed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it might be useful to enforce FOM at certain locations, where the user can already expect high fluctuations in input/output or where maximal accuracy should be guaranteed.
Yes, that should be possible and required. But my comment was still about why the macro-scale coordinates need to be passed to the switching function. I look at the switching function as a function to be called individually at each location. If the switching mechanism requires a macro-scale location, it can be passed on a per-micro-scale simulation basis. I think having a single call-type switching mechanism is beneficial for the user.
Co-authored-by: Ishaan Desai <[email protected]>
Co-authored-by: Ishaan Desai <[email protected]>
Co-authored-by: Ishaan Desai <[email protected]>
Co-authored-by: Ishaan Desai <[email protected]>
Co-authored-by: Ishaan Desai <[email protected]>
Co-authored-by: Ishaan Desai <[email protected]>
Added support for multiple micro models and mocked switching.
Multi-Model support via ModelAdaptivity class.
Switching currently hard coded as: upper half of all sims in the micro_sims list are set to use the second MicroSim type.
Checklist:
CHANGELOG.md.