Add total as alias for _GLOBAL in analyze#23
Merged
fsimonis merged 1 commit intoprecice:mainfrom Feb 27, 2026
Merged
Conversation
Contributor
Author
|
@IshaanDesai plz review |
fsimonis
changed the title
total not working as alias for _GLOBAL in --event argument #18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18
Problem
The
totalevent shown in the tabular view is stored internally as_GLOBAL.When a user passed
--event total, it failed to match correctly because thelookup compared against the raw internal name in the database.
Fix
Added a translation at the start of
analyzeCommandthat maps the displayname
totalback to the internal name_GLOBALbefore any lookup is performed.Now both of these work correctly:
precice-cli profiling analyze <participant> --event totalprecice-cli profiling analyze <participant> --event _GLOBAL