Fix: make participant argument optional, analyze all if omitted (#7)#24
Open
AdityaGupta716 wants to merge 4 commits intoprecice:mainfrom
Open
Fix: make participant argument optional, analyze all if omitted (#7)#24AdityaGupta716 wants to merge 4 commits intoprecice:mainfrom
AdityaGupta716 wants to merge 4 commits intoprecice:mainfrom
Conversation
Contributor
Author
|
@fsimonis @IshaanDesai Plz review |
|
This pull request has been mentioned on preCICE Forum on Discourse. There might be relevant details there: https://precice.discourse.group/t/gsoc-2026-aditya-gupta/2773/1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7
Problem
Running
precice-cli profiling analyzewith no participant argument led to anerror instead of showing stats for all participants.
Fix
participantan optional positional argument (nargs="?",default=None)analyzeCommandnow loops over all participantsand displays analysis for each one
Now both of these work correctly:
precice-cli profiling analyze <participant>— analyze a single participantprecice-cli profiling analyze— analyze all participants