Skip to content

Time iteration consistency + restart file documentation#47

Merged
MakisH merged 2 commits intoprecice:developfrom
j-signorelli:timestep-restart-documentation
Jan 9, 2026
Merged

Time iteration consistency + restart file documentation#47
MakisH merged 2 commits intoprecice:developfrom
j-signorelli:timestep-restart-documentation

Conversation

@j-signorelli
Copy link
Contributor

@j-signorelli j-signorelli commented Oct 8, 2025

  • In the SU2 source code and corresponding Python examples in TestCases, the TimeIter and time variables are updated after Output is called. This PR updates the run scripts to match that, as it was for the preCICE v2 version: Revamped Adapter to Work for SU2 v7.5.0-v7.5.1, Both CHT + FSI #32.

  • Dual-timestepping (an implicit time scheme) should have any the time-varying source terms / BCs / etc. computed at the t+dt state. When importing a restart file as an initial condition, TimeIter is initialized to 1, and time to dt. In general across SU2, all time-varying "things" are computed with the time TimeIter*dt. So, when importing a restart file, computations are performed with the time-varying "things" at the correct t+dt time. Additionally, output files are then representative of the solution AT its suffix iteration number (output_000001 is the state of the solution at time dt). However, if restart files are not used as an initial condition, then TimeIter is initialized to 0, and time to 0. The computations for time-varying "things" are off by a timestep, and the output represents the solution AFTER its suffix iteration number (output_000000 is the state of the solution at time dt). More information is provided at su2code/su2#2353. The punchline is that is it better to import a restart file as an initial condition always. This is also particularly important for restarted simulations. This PR adds documentation and guidance on this note.

Closes #42

@j-signorelli j-signorelli changed the title [WIP] Time iteration consistency + restart file documentation Time iteration consistency + restart file documentation Nov 12, 2025
@j-signorelli j-signorelli marked this pull request as ready for review November 12, 2025 13:59
Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes make sense to me, thanks!

Sorry for the delay, I somehow missed the "marked ready to review".

@MakisH MakisH changed the base branch from master to develop January 9, 2026 12:45
@MakisH MakisH merged commit 79b8cb8 into precice:develop Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restart/non-restart time and TimeIter problems

2 participants