Time iteration consistency + restart file documentation#47
Merged
MakisH merged 2 commits intoprecice:developfrom Jan 9, 2026
Merged
Time iteration consistency + restart file documentation#47MakisH merged 2 commits intoprecice:developfrom
MakisH merged 2 commits intoprecice:developfrom
Conversation
This was referenced Oct 11, 2025
MakisH
approved these changes
Jan 9, 2026
Member
MakisH
left a comment
There was a problem hiding this comment.
The changes make sense to me, thanks!
Sorry for the delay, I somehow missed the "marked ready to review".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the SU2 source code and corresponding Python examples in TestCases, the
TimeIterandtimevariables are updated afterOutputis called. This PR updates the run scripts to match that, as it was for the preCICE v2 version: Revamped Adapter to Work for SU2 v7.5.0-v7.5.1, Both CHT + FSI #32.Dual-timestepping (an implicit time scheme) should have any the time-varying source terms / BCs / etc. computed at the
t+dtstate. When importing a restart file as an initial condition,TimeIteris initialized to 1, andtimetodt. In general across SU2, all time-varying "things" are computed with the timeTimeIter*dt. So, when importing a restart file, computations are performed with the time-varying "things" at the correctt+dttime. Additionally, output files are then representative of the solution AT its suffix iteration number (output_000001 is the state of the solution at time dt). However, if restart files are not used as an initial condition, thenTimeIteris initialized to 0, andtimeto0. The computations for time-varying "things" are off by a timestep, and the output represents the solution AFTER its suffix iteration number (output_000000 is the state of the solution at time dt). More information is provided at su2code/su2#2353. The punchline is that is it better to import a restart file as an initial condition always. This is also particularly important for restarted simulations. This PR adds documentation and guidance on this note.Closes #42