Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nutils solid participant #431

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Conversation

gertjanvanzwieten
Copy link
Collaborator

This PR adds a solid participant compatible only with Nutils 8, formerly part of #429.

It's a draft for now because it was discovered that the system has more damping than reference results, potentially resulting from the fully implicit first order formulation. I will do some more testing in the coming days to try and sort this out.

@uekerman uekerman self-requested a review January 9, 2024 16:22
@IshaanDesai IshaanDesai changed the base branch from master to develop January 10, 2024 08:31
@uekerman uekerman changed the base branch from develop to master January 10, 2024 08:42
@uekerman
Copy link
Member

This addition goes indeed to master as it still uses preCICE v2.

@uekerman
Copy link
Member

So the damping can be very well due to the first-order method.

flap

@uekerman uekerman marked this pull request as ready for review January 10, 2024 08:50
Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tested this, but the changes make sense.
Merging to master is fine, but please remember backporting to develop.

Copy link
Member

@uekerman uekerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could run the case, the results look reasonable and the code very clean. Thanks @gertjanvanzwieten 🙏

Let's directly merge this. We can still improve later (nonlinear model, second-order time integration).

I required to explicitly ...

pip3 install --user bottombar==2.1

Otherwise, I ran into precice/precice#1443

Patch was done here: evalf/bottombar@fd2dc3a

I will document on https://precice.org/adapter-nutils.html

@uekerman
Copy link
Member

Linter problem seems unrelated:

MD034/no-bare-urls Bare URL used [Context: "www.openfoam.com"]

@uekerman uekerman merged commit 14197c2 into precice:master Jan 10, 2024
1 of 2 checks passed
uekerman added a commit to uekerman/tutorials that referenced this pull request Jan 10, 2024
* add nutils solid participant
* Add new nutils solver to README list

---------

Co-authored-by: Benjamin Uekermann <[email protected]>
@MakisH MakisH mentioned this pull request Jan 12, 2024
@MakisH
Copy link
Member

MakisH commented Jan 19, 2024

Linter problem seems unrelated:

MD034/no-bare-urls Bare URL used [Context: "www.openfoam.com"]

FYI, the solution to this is disabling the MD034 linter rule in this file:

https://github.com/precice/tutorials/blob/14197c235d4a72d841b04d01446a21a227cf0639/.markdownlint.json

We already do that in develop:

https://github.com/precice/tutorials/blob/develop/.markdownlint.json

Since the master is not going to stay on for long, I guess it is not worth fixing and all the merging around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants