Skip to content

Water Hammer Tutorial#660

Open
franiqui wants to merge 54 commits intoprecice:developfrom
franiqui:WaterHammerTutorial
Open

Water Hammer Tutorial#660
franiqui wants to merge 54 commits intoprecice:developfrom
franiqui:WaterHammerTutorial

Conversation

@franiqui
Copy link

@franiqui franiqui commented Aug 5, 2025

This PR adds a new Partitioned Water Hammer tutorial demonstrating transient 1D–3D coupling with preCICE for compressible pipe flow.

The tutorial is particularly relevant as it provides a transient benchmark for testing the axial geometric multiscale mapping under wave-propagation conditions. Unlike steady pipe examples, this case introduces pressure waves traveling across the coupling interface, making it a meaningful validation scenario for mixed-dimensional coupling.

It includes 1D–3D and 3D-1D, as well as 1D–1D and 3D–3D configurations for comparison and validation.

Checklist:

  • I added a summary of any user-facing changes (compared to the last release) in the changelog-entries/<PRnumber>.md.

@franiqui franiqui requested a review from MakisH August 5, 2025 16:08
@franiqui franiqui self-assigned this Aug 5, 2025
Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the clean PR! See some first comments on the structure.

I have not yet looked into the codes or the parameters, I would do that once the locations of the files have converged, to not lose track of the suggestions and changes.

The 3D and 3D-3D cases run, anything with the 1D code does not at the moment, but this is probably related to my system (see also #648 (comment)).

Please add some content to the PR description as well.

franiqui and others added 24 commits October 6, 2025 12:04
Remove decorative headers
Remove decorative headers
Remove decorative headers
Remove decorative headers
Remove decorative headers
REmove decorative headers
Remove decorative headers
Remove decorative headers
Remove decorative headers
Remove decorative headers
Remove decorative headers
Remove decorative headers
Remove decorative headers
Remove decorative headers
Remove decorative headers
Remove decorative headers
Remove decorative headers
Remove decorative headers
Remove decorative headers
@MakisH
Copy link
Member

MakisH commented Feb 11, 2026

Update: I resolved a few conversations that have already been addressed. What is still open is still relevant.

This looks already very close to merging. Together, let's polish the README.md and add the 1D-1D and 3D-3D as options, since this is very low effort and high benefit.

@MakisH MakisH self-requested a review March 2, 2026 09:59
MakisH added a commit to precice/precice.github.io that referenced this pull request Mar 9, 2026
I sometimes face this issue on my system, and it might be useful for others as well.

Transferring documentation from precice/tutorials#660 (comment).
Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried all combinations, they all start and the plotting script works for all.

Some small changes in the plotting script would make this easier to use.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I now run only the 1D-3D, I get:

$ python plot-pressure.py 
[INFO] Case '3D-1D' skipped: file not found (fluid1d-right-nutils/probes.txt)
[INFO] Case '1D-1D' skipped: file not found (fluid1d-right-nutils/probes.txt)

and two identical pictures for the 1D-3D and the 3D-3D, while the latter should not be there:

Image Image

franiqui and others added 2 commits March 10, 2026 09:12
Co-authored-by: Gerasimos Chourdakis <gerasimos.chourdakis@ipvs.uni-stuttgart.de>
Co-authored-by: Gerasimos Chourdakis <gerasimos.chourdakis@ipvs.uni-stuttgart.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

3 participants