-
-
Notifications
You must be signed in to change notification settings - Fork 129
Python tutorials: Allow skipping venv setup #680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The amount of extra shellscript for this is pretty daunting. I commented on the issue that an environment variable would be way easier to integrate. |
|
Very good point, an environment variable would make everything easier and would not require input from the user. I will adapt. |
|
Switched to: if [ -z "${PRECICE_TUTORIALS_NO_VENV:-}" ]
then
python3 -m venv .venv
. .venv/bin/activate
pip install -r requirements.txt && pip freeze > pip-installed-packages.log
fi(we already use this form just fine in the OpenFOAM adapter Allwmake) Examples:
Notes:
|
closes #679
Checklist:
changelog-entries/<PRnumber>.md.