fix: warn about no pinning strategy for unused features#4065
fix: warn about no pinning strategy for unused features#4065lucascolley merged 1 commit intoprefix-dev:mainfrom
Conversation
2decb25 to
fbd8ab6
Compare
|
hey @kilian-hu ! Not sure if this was closed deliberately, but would you be interested in implementing point (1) from #4065 (comment) ? |
|
@lucascolley Sorry, no that was not intentional. I just pushed what you suggested about making the warning message more informative. I noticed that when running e.g. So I'd like to merge this as a first start so users are less confused when this happens. Does the updated warning message look alright to you? And for the future it remains to maybe implement at least a sanity check solve for unused features and also change that this warning message is shown regardless of whether the feature already existed or not. |
2077aaa to
640945d
Compare
lucascolley
left a comment
There was a problem hiding this comment.
thanks @kilian-hu, looks good to me! And your plan for potential follow-up also sounds good 👍
This PR initially tried to fix #3245 where users noticed that the dependency version pinning strategy is not applied in features that are not used by any environment. This is because right now the solver does not even run for the dependencies in an unused feature because there is no environment in which the solve could happen. One could run a sanity check solve for such an unused feature's dependencies but that would require quite some changes. For now I'd at least improve the warning that is shown when there is an unused feature and inform the user that those dependencies are not being resolved at all.