feat: implement uv-style dependency sorting and multiline formatting#5677
Open
kajal-jotwani wants to merge 9 commits intoprefix-dev:mainfrom
Open
feat: implement uv-style dependency sorting and multiline formatting#5677kajal-jotwani wants to merge 9 commits intoprefix-dev:mainfrom
kajal-jotwani wants to merge 9 commits intoprefix-dev:mainfrom
Conversation
Contributor
|
Can you add unit tests specifically for |
Contributor
Author
Thanks for the review! I’ve added unit tests for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When running
pixi add --pypiwith multiple packages, dependencies were previously written as inline arrays with inconsistent ordering, which could create unnecessary diffs when removing and re-adding packages.This PR updates PyPI dependency formatting to follow uv-style behavior:
The multiline formatting logic is adapted from uv’s reformat_array_multiline, which preserves inline and trailing comments.
Fixes #5651
How Has This Been Tested?
Added three unit tests covering sorting behavior, multiline formatting, and the remove-and-readd zero-diff case. Snapshot tests were updated accordingly.
AI Disclosure
Tools: {e.g., Claude, Codex, GitHub Copilot, ChatGPT, etc.}
Checklist:
schema/model.py.