feat: add Unicode normalization for path handling and detect case-insensitive filename collisions #1621
Conversation
…ensitive filename collisions
|
@wolfv forgot to copy the case sensitive files to PREFIX folder :DD thankfully it passes now |
|
Alright, ubuntu passes, macos doesn't, i will need to check that out too |
|
@wolfv We cannot create the test files at all on mac os due to case insensivity, same as windows :/ even if i try to make a package it would fail sadly. but i think unit tests + e2e test working on linux could be enough? |
|
Sounds good indeed! |
| fn test_find_case_insensitive_collisions_unicode() { | ||
| let files = vec
There was a problem hiding this comment.
I don't think these two (straße and STRASSE) would be the same on case-insensitive file systems.. or would they?)
There was a problem hiding this comment.
Wow, they are! Just checked locally on macOS and this is true :)
There was a problem hiding this comment.
Yup! I also checked İSTANBUL and istanbul as well, it should work correctly for all languages!
closes #1262 hopefully, i am only confident with unit tests but hopefully it passes mac os!