feat(extract): extract 7zip files #1779
Open
+147
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
lucascolley
commented
Jul 17, 2025
lucascolley
commented
Jul 17, 2025
Comment on lines
-160
to
-164
| /// Determines if a file should be extracted based on its name | ||
| fn should_extract_file(filename: &str) -> bool { | ||
| is_tarball(filename) || filename.ends_with(".zip") | ||
| } | ||
|
|
There was a problem hiding this comment.
|
now tested and working with the 7zip recipe! 7zip-feedstock\recipe on 🎋 convert_feedstock_to_v1_recipe_format [🔨?]
❯ C:\Users\lucas\.cargo\bin\rattler-build.exe build -vvv
...
2025-07-17T21:01:40.745763Z DEBUG Running build for{recipe="7zip-24.08-h9490d1a_2"}:Fetching source code: rattler_build::source::url_source: Saved download metadata to: E:\dev\feedstocks\7zip-feedstock\recipe\output\src_cache\7z2408-src_4df7a62e.7z.json
Extracting 7zip file to cache: E:\dev\feedstocks\7zip-feedstock\recipe\output\src_cache\7z2408-src_4df7a62e.7z
Copying source from url: E:\dev\feedstocks\7zip-feedstock\recipe\output\src_cache\7z2408-src_4df7a62e to E:\dev\feedstocks\7zip-feedstock\recipe\output\bld\rattler-build_7zip_1752786098\work
2025-07-17T21:01:49.521865Z INFO rattler_index: Adding 0 packages to subdir win-64.
...
✔ all tests passed!
Artifact: E:\dev\feedstocks\7zip-feedstock\recipe\output\win-64\7zip-24.08-h9490d1a_2.conda (1.22 MiB) |
lucascolley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
untested