Test suite cleanups #2302
Merged
Test suite cleanups #2302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarod42
approved these changes
Oct 17, 2024
tritao
force-pushed
the
test-suite-cleanups
branch
2 times, most recently
from
5bf1437 to
7b1e4f4
Compare
Jarod42
approved these changes
Oct 18, 2024
This changes the test suite to always be run from a consistent working directory, avoiding having per-test workarounds like done on the PCH tests.
tritao
force-pushed
the
test-suite-cleanups
branch
from
7b1e4f4 to
5a1a645
Compare
Contributor
Author
|
Feedback addressed, should be ready to go @Jarod42 @nickclark2016 @samsinsane |
Jarod42
approved these changes
Nov 4, 2024
Contributor
Author
|
@nickclark2016 While the iron is hot, may you look at this one too? |
nickclark2016
approved these changes
Nov 10, 2024
Member
|
Any others you want me to look at before prepping for building the release? @tritao |
Contributor
Author
None atm, think I still need to revisit my other opened PRs. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Just some test suite cleanups.
How does this PR change Premake's behavior?
Test suite now is more consistent with the directory it runs the tests from.
Previous a folder was created and cluttered the root, which is fixed now.