Skip to content

Conversation

@Jarod42
Copy link
Contributor

@Jarod42 Jarod42 commented Oct 26, 2024

What does this PR do?

Forbid defines ""

How does this PR change Premake's behavior?

Error out wrong script using defines ""

Anything else we should know?

closes #2174

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

@nickclark2016 nickclark2016 merged commit 43fa514 into premake:master Oct 26, 2024
15 checks passed
@Jarod42 Jarod42 deleted the empty_defines branch October 26, 2024 03:10
noresources pushed a commit to depinxi/premake-core that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

<command-line>: error: macro names must be identifiers

2 participants