-
-
Notifications
You must be signed in to change notification settings - Fork 640
Add TSan and UBSan to sanitize options #2315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
website/docs/sanitize.md
Outdated
| | Thread | Enables compiler support for ThreadSanitizer. | | ||
| | Undefined | Enables compiler support for UndefinedBehaviorSanitizer (UBSan). | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
supported only by gcc/clang
Check also if msvc with clang toolset can support it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-cl supports passing -fsanitize=undefined to it, but I am unable to find a corresponding vcxproj flag for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just keeping it with gcc/clang without MSVC/MSBuild support is perfectly sufficient for now.
|
|
|
Failing lines: test_clang.lua: test_gcc.lua: |
|
Regarding Clang libFuzzer, I can make the test pass, but I believe that the existing implementation might be wrong? |
|
I can revert the last commit (69bf538) and also the test changes for clang, and put them into another PR if desired. |
What does this PR do?
Add TSan and UBSan to the list of sanitize options
How does this PR change Premake's behavior?
It is possible for users to enable TSan and UBSan now.
Anything else we should know?
I'm unable to run the tests so I'm unsure if they actually pass.
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!