updated dotnetbase to generate configurations list in opening propert… #2320
Conversation
…ygroup containing project properties (fix for incorrect cofigurationmapping) (tests required)
| for prjcfg in project.eachconfig(prj) do | ||
| _p(3,'%s;',prjcfg.shortname) | ||
| end |
There was a problem hiding this comment.
Wonder if we can use something like table.implode(arr, "before", "after", "between") to avoid extra ';'.
There was a problem hiding this comment.
il give that a try now
There was a problem hiding this comment.
it worked but i can't figure out how to make it auto generate in the initial property group
| -- | ||
| -- Write the available configurations to have correct configuration mapping on vs2022 format and later. | ||
| -- | ||
| function dotnetbase.projectConfigurations(prj) |
There was a problem hiding this comment.
That function is never called.
There was a problem hiding this comment.
i know, i don't kown where to put so it gets placed in the primary property group.
| <OutputType>Exe</OutputType> | ||
| <AppDesignerFolder>Properties</AppDesignerFolder> | ||
| <TargetFramework>net8.0</TargetFramework> | ||
| <Configurations>Debug;Release</Configurations> |
There was a problem hiding this comment.
"Distribution" seems missing...
|
|
||
| configurations { "Debug","Release","Distribution"} | ||
| test.capture [[ | ||
| <PropertyGroup> |
There was a problem hiding this comment.
From UT, indentation seems mismatching: check number of spaces or tab?
samsinsane
left a comment
samsinsane
left a comment
There was a problem hiding this comment.
As you've been told in your other PR multiple times, use spaces in lists and function arguments. a, b, c not a,b,c.
|
yea sorry for the spacing will try and fix that this week! |
|
|
|
my brain was having some ID10T erros :) |
3 participants
…ygroup containing project properties
(fix for incorrect cofigurationmapping) (tests required)
What does this PR do?
Thanks for the contribution! Please provide a concise description of the problem this request solves.
this pr closes #2319
Are there any breaking changes? Will any existing behavior change?
Anything else we should know?
should documentation be changed to tell people about this because it is auto genrated from vs2022 onwards
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!