Remove Deprecated Flags with Replacements, Fix Tests #2331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickclark2016
force-pushed
the
feature/remove-deprecated-flags-with-existing-replacements
branch
from
0667cc1 to
b287ada
Compare
samsinsane
approved these changes
Nov 20, 2024
Member
samsinsane
left a comment
samsinsane
left a comment
There was a problem hiding this comment.
Comments don't need to be addressed in this PR, can be merged as-is.
tritao
approved these changes
Nov 20, 2024
nickclark2016
force-pushed
the
feature/remove-deprecated-flags-with-existing-replacements
branch
from
b287ada to
e1f3cf2
Compare
tritao
approved these changes
Nov 20, 2024
samsinsane
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the remaining flags that are deprecated and have existing replacements. Fixes unit tests corresponding to those removals. This also fixes an issue in xcode where the "StaticRuntime" flag was being used in the generator instead of the "staticruntime" field.
How does this PR change Premake's behavior?
Will break any code using those flags.
Anything else we should know?
Further clean up ahead of the 5.0 release.
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!