-
-
Notifications
You must be signed in to change notification settings - Fork 640
Deprecate FatalWarnings flags in favor of fatalwarnings API #2347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate FatalWarnings flags in favor of fatalwarnings API #2347
Conversation
Jarod42
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing filterFatalWarnings might make sense, i.e:
fatalwarnings { "Link", "4996" }
samsinsane
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see that src/tools/clang.lua hasn't been modified, I assume it needs to be updated?
0fed005 to
e82febe
Compare
samsinsane
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a future PR, we should consider an All value for those that used FatalWarnings before.
What does this PR do?
Moves the existing
FatalWarnings,FatalCompileWarnings, andFatalLinkWarningsflags to the existingfatalwarningsAPI.How does this PR change Premake's behavior?
Deprecates the
FatalWarnings(and friends) flags. Translates the calls to:Anything else we should know?
Deprecation of flags ahead of 5.0 release.
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!