Skip to content

Conversation

@nickclark2016
Copy link
Member

What does this PR do?

Moves the existing FatalWarnings, FatalCompileWarnings, and FatalLinkWarnings flags to the existing fatalwarnings API.

How does this PR change Premake's behavior?

Deprecates the FatalWarnings (and friends) flags. Translates the calls to:

flags { "FatalWarnings" }
-- becomes
fatalwarnings { "Compile", "Link" }

flags { "FatalCompileWarnings" }
-- becomes
fatalwarnings { "Compile" }

flags { "FatalLinkWarnings" }
-- becomes
fatalwarnings { "Link" }

Anything else we should know?

Deprecation of flags ahead of 5.0 release.

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

@nickclark2016 nickclark2016 requested a review from a team November 28, 2024 04:13
Copy link
Contributor

@Jarod42 Jarod42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing filterFatalWarnings might make sense, i.e:

fatalwarnings { "Link", "4996" }

Copy link
Member

@samsinsane samsinsane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see that src/tools/clang.lua hasn't been modified, I assume it needs to be updated?

@nickclark2016 nickclark2016 force-pushed the flags/fatalwarnings-replace branch from 0fed005 to e82febe Compare November 29, 2024 17:52
Copy link
Member

@samsinsane samsinsane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a future PR, we should consider an All value for those that used FatalWarnings before.

@samsinsane samsinsane merged commit 3f4090a into premake:master Dec 1, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants