Fatal warnings API fixes #2382
Merged
Fatal warnings API fixes #2382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatalwarnings("All") applies to the compiler, linkerfatalwarnings("All") to the linker
Implemented linker warnings as errors in MSVC
Change the special values "Compiler" and "Link" to "All" for each api
Add reserved values for APIs that need a value with special meaning while allowing other strings to pass through unmodified
Fixed incorrect linker unit test and added linker unit tests for VS2022
Jarod42
reviewed
Dec 18, 2024
Jarod42
reviewed
Dec 19, 2024
Contributor
|
Failed
but unrelated to the PR. |
Jarod42
approved these changes
Dec 20, 2024
nickclark2016
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Splits the fatalwarnings api into fatalwarnings for compiler and linkerfatalwarnings for linker. Changes the special Compile and Link values to All in each api. Implements fatal warnings for the linker in VS2022
How does this PR change Premake's behavior?
Changes the fatalwarnings api
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!