Updated gmake and gmakelegacy generators so that GCC dependency flags come from the toolset #2511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… come from the toolset
Jarod42
reviewed
Sep 17, 2025
| local flags = config.mapFlags(cfg, gcc.cppflags) | ||
|
|
||
| -- Request that dependencies be written out | ||
| table.insert(flags, '-MF "$(@:%.o=%.d)"') |
Contributor
There was a problem hiding this comment.
Isn't $(@:%.o=%.d) Makefile specific? :-(
In premake-ninja, we hard code the rule with -MF $out.d
Member
Author
There was a problem hiding this comment.
Oops, overlooked that. Thanks for pointing that out, going to close this, need to come up with a different approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updated gmake and gmakelegacy generators so that GCC dependency flags come from the toolset.
How does this PR change Premake's behavior?
gmake and gmakelegacy will no longer emit the GCC dependency flag. GCC and Clang emit it. This may cause issues for modules that add new C and C++ toolsets and don't return the GCC/Clang cppflags.
Anything else we should know?
N/A.
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!