Add premake icon as resource for windows #2523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyrietS
approved these changes
Oct 20, 2025
Member
KyrietS
left a comment
KyrietS
left a comment
There was a problem hiding this comment.
I'm not sure why it has this light edge but other than that it's great 👍
samsinsane
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add premake ico inside exe on windows
How does this PR change Premake's behavior?
No behavior change
Anything else we should know?
premake.ico is copied from website\static\img\favicon.ico
as relative path seems not supported in resource.
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)