Skip to content

Conversation

@Jarod42
Copy link
Contributor

@Jarod42 Jarod42 commented Oct 30, 2025

What does this PR do?

close #2522

How does this PR change Premake's behavior?

visual project with clang now handle disablewarnings

Anything else we should know?

Also tested on my sample-test-project

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

@samsinsane samsinsane merged commit ea22ef0 into premake:master Oct 30, 2025
47 of 49 checks passed
@Jarod42 Jarod42 deleted the disablewarnings_vs_with_clang branch October 30, 2025 09:09
Jarod42 added a commit to Jarod42/premake-core that referenced this pull request Nov 6, 2025
Jarod42 added a commit to Jarod42/premake-core that referenced this pull request Nov 6, 2025
Jarod42 added a commit to Jarod42/premake-core that referenced this pull request Nov 6, 2025
samsinsane pushed a commit that referenced this pull request Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

disablewarnings not handled in visual studio with clang

2 participants