fix visual studio LinkTimeOptimization default not setting WholeProgramOptimization to true #2549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amOptimization to true default for newly created .vcxproj in Visual Studio is WholeProgramOptimization set to true, but LinkTimeCodeGeneration unset, resulting in the default LTCG:Incremental being used this got overlooked in the api change for LinkTimeOptimization from flags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix visual studio LinkTimeOptimization default not setting WholeProgramOptimization to true
default for newly created .vcxproj in Visual Studio is WholeProgramOptimization set to true, but LinkTimeCodeGeneration unset, resulting in the default LTCG:Incremental being used
this got overlooked in the api change for LinkTimeOptimization from flags
What does this PR do?
^ see commit description
How does this PR change Premake's behavior?
This changes the behaviour for vc2010 projects when using LinkTimeOptimization "Default".
Anything else we should know?
Context: #2343
I'm realising that the "default" is probably actually the "default" and will change all vs2010 projects. Maybe it would be better to add an "incremental" option in addition to "on", "off", "default", so LTCG:incremental can be used?
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!