Utilize existing tool version functionality for toolchainversion #2594
+484
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarod42
reviewed
Jan 7, 2026
| local value = p.action.current().toolset | ||
| tool, version = p.tools.canonical(value) | ||
| end | ||
| local toolset = p.tools.normalize(cfg.toolset):explode("-", true, 1) |
Contributor
There was a problem hiding this comment.
I think it should be something like
local toolset, toolset_version = p.tools.canonical(cfg.toolset)
Member
Author
There was a problem hiding this comment.
canonical returns the tool table itself, I need the name.
| if version then | ||
| m.element("PlatformToolset", nil, version) | ||
| m.element("PlatformToolset", nil, ts) | ||
| elseif cfg.toolchainversion then |
Member
Author
There was a problem hiding this comment.
For Linux, yes. It's tricky to properly deprecate this with a clean mapping of values (it is dependent on the toolset and toolchain version), so we need this code to live until we 100% remove toolchainversion.
nickclark2016
force-pushed
the
normalize-toolchain-versions
branch
from
9409ea5 to
5ee4404
Compare
samsinsane
approved these changes
Jan 8, 2026
redorav
reviewed
Jan 8, 2026
|
|
||
| function suite.linkTimeOptimization_On() | ||
| linktimeoptimization('on') | ||
| toolset('gcc-remote') |
Collaborator
There was a problem hiding this comment.
I guess the flexibility of this approach is that if there is ever a Remote_GCC_1_1 we can always extend this to gcc-remote-1.1 or whatever
redorav
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Merges
toolchainversionfunctionality withtoolset. Deprecatestoolchainversionin favor of a single way to specify tooling versions. This also makes it clearer how versions get specified.How does this PR change Premake's behavior?
No behavior changes.
Anything else we should know?
Preparation for 5.0
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!