fix: missing -fopenmp ldflags in gcc/clang when openmp is on#2639
Merged
nickclark2016 merged 2 commits intopremake:masterfrom Mar 11, 2026
Merged
fix: missing -fopenmp ldflags in gcc/clang when openmp is on#2639nickclark2016 merged 2 commits intopremake:masterfrom
-fopenmp ldflags in gcc/clang when openmp is on#2639nickclark2016 merged 2 commits intopremake:masterfrom
Conversation
nickclark2016
approved these changes
Mar 11, 2026
Member
nickclark2016
left a comment
nickclark2016
left a comment
There was a problem hiding this comment.
In the future, please squash into a single commit locally. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix premake wasn't adding
-fopenmpto ldflags in gcc/clang when openmp is on. Without this flag, the program will fail to build with errors such as "undefined reference to `omp_get_thread_num'".How does this PR change Premake's behavior?
-fopenmpis added to ldflags in the generated makefiles, solinkoptions { "-fopenmp" }is no longer required.Anything else we should know?
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!