-
Notifications
You must be signed in to change notification settings - Fork 30
Add test coverage for UME #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
etherealsunshine
wants to merge
27
commits into
prescient-design:main
Choose a base branch
from
etherealsunshine:add_test_coverage_ume
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add test coverage for UME #169
etherealsunshine
wants to merge
27
commits into
prescient-design:main
from
etherealsunshine:add_test_coverage_ume
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncfrey
reviewed
Jul 30, 2025
karinazad
reviewed
Jul 30, 2025
karinazad
reviewed
Jul 30, 2025
karinazad
reviewed
Jul 30, 2025
I'm actually working on making Nathan's |
let me know if these changes look good! |
karinazad
reviewed
Aug 1, 2025
karinazad
reviewed
Aug 1, 2025
karinazad
reviewed
Aug 1, 2025
karinazad
reviewed
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves test coverage for the UME model class. Addresses #80
What's added
test_malformed_smiles_behavior
- Documents how UME handles invalid SMILES stringstest_malformed_protein_behavior
- Tests UME's robustness with invalid protein sequencesFeatures
Usage
# Run the new robustness tests pytest tests/lobster/model/test__ume.py::TestUME::test_malformed_smiles_behavior -v pytest tests/lobster/model/test__ume.py::TestUME::test_malformed_protein_behavior -v
Type of Change
Testing
Checklist