Fix VimuxOpenRunner not working for versions of tmux < 3.4#228
Merged
alerque merged 2 commits intopreservim:masterfrom Jul 27, 2024
Merged
Fix VimuxOpenRunner not working for versions of tmux < 3.4#228alerque merged 2 commits intopreservim:masterfrom
alerque merged 2 commits intopreservim:masterfrom
Conversation
mvanderkamp
approved these changes
Jul 26, 2024
Member
mvanderkamp
left a comment
There was a problem hiding this comment.
Thanks! This could cause some confusion for anyone who has set this variable but that is easily fixed by users.
alerque
approved these changes
Jul 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for #225 to allow VimuxOpenRunner to work for versions of tmux < 3.1
The breaking change was introduced in #217 and was caused because even though the
-lflag existed for a long time, it never supported percentage signs until tmux 3.1. Relevant part of their CHANGESThis is an old tmux version so in my opinion the most logical thing is to support by default the newer tmux syntax. The default for
g:VimuxHeightis20%.This won't support the old tmux flag
-pso for older versions you'd only be able to specify the size of the split in columns/lines.