Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pull_request_template.md to remove PR link examples #24477

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

steveburnett
Copy link
Contributor

@steveburnett steveburnett commented Feb 3, 2025

Description

Removed manual PR link examples from pull_request_template.md.

Motivation and Context

PR #24354 automatically adds links to the PR to the release note, so manually adding PR links to the release note entry for a PR is now redundant.

I have updated the Release Notes Guidelines to remove the examples of manually adding the PR link.

Impact

New pull requests.

Test Plan

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@steveburnett steveburnett self-assigned this Feb 3, 2025
@steveburnett steveburnett requested a review from a team as a code owner February 3, 2025 15:32
@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Feb 3, 2025
@prestodb-ci prestodb-ci requested review from a team, nishithakbhaskaran and jp-sivaprasad and removed request for a team February 3, 2025 15:32
@tdcmeehan tdcmeehan merged commit a0c9b23 into prestodb:master Feb 4, 2025
54 checks passed
@steveburnett steveburnett deleted the steveburnett-pr-template branch February 4, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:IBM PR from IBM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants