-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Mixed case identifier support #24551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6f127fc
to
e2f23fd
Compare
1ad263b
to
bcb3a7c
Compare
0e0c8be
to
8e65855
Compare
8f48ca4
to
63944ed
Compare
@ethanyzhang imported this issue into IBM GitHub Enterprise |
b0a5dd9
to
76cb96e
Compare
@ethanyzhang imported this issue into IBM GitHub Enterprise |
76cb96e
to
30d669e
Compare
0b2ca4c
to
37e9ca9
Compare
ScrapCodes
previously approved these changes
May 18, 2025
ZacBlanco
reviewed
May 21, 2025
presto-base-jdbc/src/main/java/com/facebook/presto/plugin/jdbc/BaseJdbcConfig.java
Show resolved
Hide resolved
presto-tests/src/main/java/com/facebook/presto/tests/AbstractTestQueryFramework.java
Outdated
Show resolved
Hide resolved
presto-tests/src/main/java/com/facebook/presto/tests/AbstractTestQueryFramework.java
Show resolved
Hide resolved
presto-product-tests/src/main/java/com/facebook/presto/tests/hive/TestHiveMixedCaseSupport.java
Outdated
Show resolved
Hide resolved
37e9ca9
to
79e5c14
Compare
79e5c14
to
0bee1ec
Compare
ZacBlanco
previously approved these changes
May 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for this big effort! I have one remaining request about the warnings, otherwise I am happy with this.
presto-base-jdbc/src/main/java/com/facebook/presto/plugin/jdbc/BaseJdbcClient.java
Outdated
Show resolved
Hide resolved
e1b1cfb
to
be5f74f
Compare
ZacBlanco
reviewed
May 29, 2025
presto-base-jdbc/src/main/java/com/facebook/presto/plugin/jdbc/JdbcWarningCode.java
Outdated
Show resolved
Hide resolved
be5f74f
to
df2447d
Compare
ZacBlanco
previously approved these changes
Jun 2, 2025
hantangwangd
previously approved these changes
Jun 2, 2025
df669d2
df2447d
to
df669d2
Compare
ZacBlanco
approved these changes
Jun 9, 2025
hantangwangd
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves identifier handling (schema, table) to align with SQL standards for better compatibility with case-sensitive and case-normalizing databases, while minimizing SPI-breaking changes.
Motivation and Context
RFC details - prestodb/rfcs#36
This PR focuses on generalizing schema and table name handling to better align with SQL standards. As per the current API behavior, identifiers are lowercased by default unless explicitly handled (RFC reference).
Column name support and related changes will be addressed in a follow-up PR. Currently, column names are lowercased at the SPI level (ColumnMetadata.java#L45). Removing this generic lowercase conversion will require updates to normalize column names via the metadata API in each connector.
Impact
Improves identifier handling (schema, table) to align with SQL standards for better compatibility with case-sensitive and case-normalizing databases, while minimizing SPI-breaking changes.
Here is how Analysis Time on local Mac with 8GB JVM for

EXPLAIN
TPCH Queries, tpch-sf100 with (master) and with the PR changes -Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.