Skip to content

Add new fields to HiveFileContext #25588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2025
Merged

Add new fields to HiveFileContext #25588

merged 1 commit into from
Jul 23, 2025

Conversation

NikhilCollooru
Copy link
Contributor

@NikhilCollooru NikhilCollooru commented Jul 21, 2025 •
edited
Loading

Description

Add new fields to HiveFileContext

Motivation and Context

Add new fields to HiveFileContext so that we can use it for logging in underlying systems.

Impact

None

Test Plan

unit tests

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@NikhilCollooru NikhilCollooru requested a review from a team as a code owner July 21, 2025 17:47
@prestodb-ci prestodb-ci added the from:Meta PR from Meta label Jul 21, 2025
@NikhilCollooru NikhilCollooru force-pushed the extHiveFileContext branch 2 times, most recently from bfe48aa to 9c07379 Compare July 21, 2025 18:11
shangm2
shangm2 approved these changes Jul 21, 2025
View reviewed changes
Copy link
Contributor

@shangm2 shangm2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NikhilCollooru NikhilCollooru merged commit 11383c2 into prestodb:master Jul 23, 2025
114 checks passed
@NikhilCollooru NikhilCollooru deleted the extHiveFileContext branch July 23, 2025 17:10
@jaystarshot
Copy link
Member

Are corresponding changes needed in prestoToVeloxConnector?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rschlussel rschlussel rschlussel approved these changes

@shangm2 shangm2 shangm2 approved these changes

Assignees
No one assigned
Labels
from:Meta PR from Meta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NikhilCollooru @jaystarshot @rschlussel @shangm2 @prestodb-ci