Skip to content

Conversation

skyelves
Copy link
Contributor

Differential Revision: D81229069

@skyelves skyelves requested review from a team as code owners September 16, 2025 23:30
Copy link

linux-foundation-easycla bot commented Sep 16, 2025

CLA Not Signed

Copy link
Contributor

sourcery-ai bot commented Sep 16, 2025

Reviewer's Guide

Introduces an overload of toVeloxConfigs to include extraCredentials from TaskUpdateRequest into QueryConfig and updates QueryContextManager to use it, with minor refactors for move semantics and code formatting.

File-Level Changes

Change Details Files
Added overload for toVeloxConfigs to handle TaskUpdateRequest and merge extraCredentials.
  • Created toVeloxConfigs(const TaskUpdateRequest&) that calls the session-based overload
  • Merged extraCredentials into a copied raw config map
  • Returned a new QueryConfig constructed with std::move(configs)
PrestoToVeloxQueryConfig.cpp
PrestoToVeloxQueryConfig.h
Updated QueryContextManager to use the new TaskUpdateRequest overload.
  • Replaced toVeloxConfigs(session) with toVeloxConfigs(taskUpdateRequest)
QueryContextManager.cpp
Refactored QueryConfig constructor calls and formatting tweaks.
  • Changed QueryConfig(configs) to QueryConfig(std::move(configs))
  • Adjusted formatting of folly::join for clientTags
PrestoToVeloxQueryConfig.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@facebook-github-bot
Copy link
Collaborator

@skyelves has exported this pull request. If you are a Meta employee, you can view the originating diff in D81229069.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

skyelves pushed a commit to skyelves/presto that referenced this pull request Sep 17, 2025
@facebook-github-bot
Copy link
Collaborator

@skyelves has exported this pull request. If you are a Meta employee, you can view the originating diff in D81229069.

@facebook-github-bot
Copy link
Collaborator

@skyelves has exported this pull request. If you are a Meta employee, you can view the originating diff in D81229069.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants