Linked STARTMENU labels to the entries of sStartMenuActionTable #694
+9
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to remove options from the start menu at will. Looking for a STARTMENU label and removing it from enum StartMenuOption and the SetUpStartMenu functions isn't good enough by itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While I was trying to help someone over at PokeCommunity I noticed that in order to quickly remove access to one of the game's start menu options, one had to update not only the places where said start menu option's
STARTMENUlabel is used, but alsosStartMenuActionTable, the table that links each start menu option's text string and main callback function together.Since this connection might not be obvious to potential users, I decided to quickly link the
STARTMENUlabels with the entries on that table to make it easier to understand.Aligning the table's labels was an extra, something I just did it on a whim :P ... let me know if it was uncalled for.
Discord contact info
lunos4026