Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactorize check button pressed #340

Merged
merged 3 commits into from
Nov 5, 2021
Merged

Refactorize check button pressed #340

merged 3 commits into from
Nov 5, 2021

Conversation

kqesar
Copy link
Contributor

@kqesar kqesar commented Nov 5, 2021

As suggested by @Rangi42 in #302 i have cleaned comment for buttons

@Rangi42 Rangi42 changed the title feat():Refactorize check button pressed Refactorize check button pressed Nov 5, 2021
Rangi42
Rangi42 reviewed Nov 5, 2021
View reviewed changes
engine/menus/text_box.asm Outdated Show resolved Hide resolved
Rangi42
Rangi42 reviewed Nov 5, 2021
View reviewed changes
engine/menus/text_box.asm Outdated Show resolved Hide resolved
Rangi42
Rangi42 reviewed Nov 5, 2021
View reviewed changes
engine/menus/text_box.asm
@@ -296,7 +296,7 @@ DisplayTwoOptionMenu:
pop hl
.noYesMenuInputLoop
call HandleMenuInput
bit 1, a ; A button pressed?
bit BIT_B_BUTTON, a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch with this incorrect comment. =)

Rangi42
Rangi42 approved these changes Nov 5, 2021
View reviewed changes
Copy link
Member

@Rangi42 Rangi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replacing magic numbers with constants and removing redundant comments is very helpful, thank you!

@Rangi42 Rangi42 merged commit 8349bfd into pret:master Nov 5, 2021
SatoMew added a commit to SatoMew/pokered that referenced this pull request Mar 26, 2022
@SatoMew
Squashed commit of the following:
e922b6f 
commit fe8d3c5
Author: vulcandth <[email protected]>
Date:   Sat Mar 26 15:59:36 2022 -0500

    Build the Virtual Console patches with `make red_vc` and `make blue_vc`  (pret#351)

commit 07df4a5
Author: Rangi <[email protected]>
Date:   Thu Mar 17 20:36:13 2022 -0400

    Refactor pkmncompress.c to use common.h

    Fixes pret#349

commit 570d83b
Author: Rangi <[email protected]>
Date:   Tue Mar 15 17:35:30 2022 -0400

    Use noreturn for usage_exit

commit e175577
Author: Rangi <[email protected]>
Date:   Tue Mar 15 17:29:07 2022 -0400

    Use -flto for all tools

commit a75dd22
Author: Rangi <[email protected]>
Date:   Tue Mar 8 21:52:57 2022 -0500

    Slightly refactor some C tools

commit 7e78c11
Author: Rangi <[email protected]>
Date:   Fri Mar 4 18:21:12 2022 -0500

    Gen 1's Minimize graphic was not a complete 8x8 tile

commit 9523681
Author: stringflow <[email protected]>
Date:   Thu Dec 9 17:30:15 2021 +0100

    Fix incorrect comment about money received after battle (pret#346)

    * fix incorrect comment about money received after battle

    * fix incorrect comment in wram.asm

commit 09e92c5
Author: Rangi <[email protected]>
Date:   Tue Nov 23 21:00:07 2021 -0500

    Use ~X instead of $ff ^ X

commit 865d37e
Author: Rangi <[email protected]>
Date:   Tue Nov 23 20:56:57 2021 -0500

    Use compound assignment operators

commit 64e2b66
Author: Rangi <[email protected]>
Date:   Tue Nov 23 20:53:05 2021 -0500

    Require rgbds 0.5.2

commit 157b593
Author: Rangi <[email protected]>
Date:   Sat Nov 6 13:24:19 2021 -0400

    Use `dn` for wave instrument samples, like pokecrystal

commit f68af5c
Author: Yoann Fievez <[email protected]>
Date:   Sat Nov 6 00:45:09 2021 +0100

    Add some constants for options (pret#344)

    Co-authored-by: Rangi <[email protected]>

commit 8349bfd
Author: Yoann Fievez <[email protected]>
Date:   Fri Nov 5 20:40:15 2021 +0100

    Refactorize check button pressed (pret#340)

commit b44a10a
Author: Yoann Fievez <[email protected]>
Date:   Thu Nov 4 20:17:17 2021 +0100

    Update 'make compare' for no pret repo and add 'make' for fork (pret#339)

commit 2ee8ce2
Author: Rangi <[email protected]>
Date:   Wed Nov 3 17:07:08 2021 -0400

    Comment on the CooltrainerFAI bug

    Fixes pret#308

commit e4845d3
Merge: 58d08bf 0af787e
Author: Rangi <[email protected]>
Date:   Tue Nov 2 19:58:17 2021 -0400

    Merge branch 'master' of https://github.com/pret/pokered

commit 58d08bf
Author: Rangi <[email protected]>
Date:   Tue Nov 2 19:57:08 2021 -0400

    Identify some percentage constant values

commit 0af787e
Author: IIMarckus <[email protected]>
Date:   Fri Oct 8 04:30:39 2021 -0600

    Kill Freenode.

commit fc899e1
Author: Rangi <[email protected]>
Date:   Tue Oct 5 21:02:42 2021 -0400

    `warp_event` warp IDs start at 1, like in pokegold/pokecrystal

commit 5266001
Author: Rangi <[email protected]>
Date:   Tue Oct 5 20:46:46 2021 -0400

    Clean up some redundant or unusual event comments

commit d48a318
Author: Rangi <[email protected]>
Date:   Sun Sep 26 23:20:57 2021 -0400

    Align `object_event` coordinates

    Fixes pret#336

commit 30acb46
Author: Amber Brault <[email protected]>
Date:   Sun Sep 26 22:57:55 2021 -0400

    Fix typos (pret#334)

commit 2c4f358
Author: Yoann Fievez <[email protected]>
Date:   Mon Sep 27 04:56:09 2021 +0200

    Unify map event gen1 gen2 (pret#335)

    * Update sign to bg_event pret#289

    * Rename warp to warp_event

    * Replace object to object_event

    * Move warp macro parameter from warp x, y, id, map to warp_event x, y, map, id

commit f1285f8
Author: Rangi <[email protected]>
Date:   Wed Sep 8 20:59:22 2021 -0400

    `ASSERT LOW(wSpriteStateData1) == 0 && LOW(wSpriteStateData2) == 0`

commit 7ee8a65
Author: Rangi <[email protected]>
Date:   Sat Aug 28 17:02:20 2021 -0400

    wcf4b -> wStringBuffer

commit 2364261
Author: SatoMew <[email protected]>
Date:   Sun Aug 1 03:53:52 2021 +0100

    Remove old tile animation comments (pret#333)

    They stopped being accurate after pret#304 and aren't really necessary.
@kqesar kqesar deleted the use_constants_button branch November 24, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rangi42 Rangi42 Rangi42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kqesar @Rangi42