Use constants for PP masks instead of magic numbers #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rangi42
requested changes
Apr 1, 2025
Contributor
Author
|
@Rangi42 I've made the requested changes |
Rangi42
reviewed
Apr 2, 2025
PokefanMarcel
pushed a commit
to PokefanMarcel/yumepokered
that referenced
this pull request
Jun 21, 2025
superdanfran
pushed a commit
to superdanfran/pokered
that referenced
this pull request
Jul 29, 2025
CreamElDudJafar
pushed a commit
to CreamElDudJafar/pokered-yellow-colors
that referenced
this pull request
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the constants
PP_UP_MASKandPP_VALUE_MASKand replaces the hardcoded values with them.I wasn't sure which file to put this in, since they are used in many different places. move_constants.asm seemed the most fitting.
Fixes part of #479