Skip to content

Label cleanup, add some constants instead of raw numbers #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 3, 2025
Merged

Label cleanup, add some constants instead of raw numbers #528

merged 3 commits into from
Sep 3, 2025

Conversation

@Narishma-gb
Copy link
Contributor

@Narishma-gb Narishma-gb commented Sep 1, 2025

  • Added the new constants in hardware.inc when writing to rLCDC. LCDC_DEFAULT is moved out of init.asm, because it's used in 2 more files. Is gfx_constants.asm a suitable location?
  • Removed LoadMissableObjects, this symbol is unused and was initially assumed to be the target of a Predef function.
  • Added UnusedOpenBillsPC to set it apart from the text data immediately above.
  • Removed some redundant comments.
  • Fix some constants in Route2Gate.asm and SeafoamIslandsB4F.asm.
  • I am not very familiar with SGB-SNES video transfer, I'd welcome comments on changes to CopyGfxToSuperNintendoVRAM.

Rangi42
Rangi42 previously requested changes Sep 1, 2025
View reviewed changes
Copy link
Member

@Rangi42 Rangi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a few changes to request.

Rangi42
Rangi42 reviewed Sep 3, 2025
View reviewed changes
@Rangi42 Rangi42 dismissed their stale review September 3, 2025 15:53

Resolved

@Rangi42 Rangi42 merged commit 4d2594c into pret:master Sep 3, 2025
1 check passed
github-actions bot pushed a commit that referenced this pull request Sep 3, 2025
@Rangi42
Label and constant cleanup (#528)
7657950 
* Label cleanup, add some constants instead of raw numbers

* Rename load/save game functions to be more explicit
UberArsenal added a commit to UberArsenal/pokered that referenced this pull request Sep 19, 2025
@UberArsenal
Squashed commit of the following:
d36fe62 
commit 3541e8129556895a1d0a884746dede191edc9f77
Author: UberArsenal <[email protected]>
Date:   Fri Sep 19 12:37:04 2025 -0400

    Squashed commit of the following:

    commit 0485c9e
    Author: UberArsenal <[email protected]>
    Date:   Fri Sep 19 12:30:39 2025 -0400

        Fix Professor Oak trainer set for Bulbasaur players

commit 943eeb6
Author: UberArsenal <[email protected]>
Date:   Fri Sep 19 12:07:48 2025 -0400

    Add prompt to reuse repel when effect ends

commit 59da8c8
Author: PokefanMarcel <[email protected]>
Date:   Wed Sep 10 21:48:30 2025 +0200

    Clean up home/copy2.asm (pret#531)

    * Use `SCREEN_WIDTH`, rename loop, and remove obsolete comment in `ClearScreenArea`

    * Use `SCREEN_HEIGHT` and `lb` in `CopyScreenTileBufferToVRAM`

    * Use `SCREEN_AREA` in `ClearScreen`

commit 108bf29
Author: PokefanMarcel <[email protected]>
Date:   Sun Sep 7 18:46:26 2025 +0200

    Use RAMG_SRAM_ENABLE (pret#530)

commit b496791
Author: PokefanMarcel <[email protected]>
Date:   Wed Sep 3 18:01:15 2025 +0200

    Document visual glitch with Pewter City Gym guy (pret#526)

commit 8da7deb
Author: Vortyne <[email protected]>
Date:   Wed Sep 3 11:59:22 2025 -0400

    Update comment for clarity (pret#529)

    Actually copies from battle struct to party struct to make HP and status changes to a pokemon permanent

commit 4d2594c
Author: Narishma-gb <[email protected]>
Date:   Wed Sep 3 17:56:09 2025 +0200

    Label and constant cleanup (pret#528)

    * Label cleanup, add some constants instead of raw numbers

    * Rename load/save game functions to be more explicit

commit d98b5e6
Author: Rangi42 <[email protected]>
Date:   Thu Aug 28 19:22:16 2025 -0400

    Document where badge and elevator floor "items" are used

commit fd5dc11
Author: Rangi42 <[email protected]>
Date:   Wed Aug 27 11:36:32 2025 -0400

    Specify file extensions that `make` does not generate

commit 126c3f3
Author: Narishma-gb <[email protected]>
Date:   Sun Aug 17 16:00:34 2025 +0200

    Document a bug in `PrintBenchGuyText` (pret#523)

commit 5e8b835
Author: Rangi <[email protected]>
Date:   Sun Aug 17 09:58:09 2025 -0400

    Use `dname` macro to automatically pad names with `"@"` characters (pret#525)

commit 31fc2e2
Author: PokefanMarcel <[email protected]>
Date:   Sat Aug 16 14:37:08 2025 +0200

    Use `<STAT>_UP1_EFFECT` constants (pret#522)

commit c51d1b7
Author: Rangi42 <[email protected]>
Date:   Wed Aug 13 15:09:12 2025 -0400

    List end markers (-1 aka $FF) are not part of table data

commit 263a35a
Author: Rangi42 <[email protected]>
Date:   Wed Aug 13 13:03:45 2025 -0400

    Say how many bytes the assertion macros expected vs got

commit 1eb6f61
Author: Rangi42 <[email protected]>
Date:   Mon Aug 11 16:31:18 2025 -0400

    Identify `JOYP_SGB_MLT_REQ` constant

commit bdbc8cb
Author: Rangi42 <[email protected]>
Date:   Mon Aug 11 15:43:27 2025 -0400

    Update hardware.inc to 5.3.0 and use its `JOYP_SGB_*` constants

commit 6f8ee8a
Author: Rangi42 <[email protected]>
Date:   Sun Aug 3 21:05:52 2025 -0400

    Try to catch missing commas in `tmhm` learnsets

commit fd86bca
Author: Rangi42 <[email protected]>
Date:   Tue Jul 22 08:59:51 2025 -0400

    Update hardware.inc to 5.2.0

commit e2f7c5c
Author: kagnusdev <[email protected]>
Date:   Fri Jul 11 23:36:45 2025 +0200

    Use hardware constants for tile attributes in VermilionDockOAMBlock (pret#516)

commit 4eaccc4
Author: kagnusdev <[email protected]>
Date:   Tue Jul 8 00:59:17 2025 +0200

    Use less generic labels for party finding loops (pret#514)

commit d6e9f53
Author: Rangi <[email protected]>
Date:   Wed Jul 2 20:17:19 2025 -0400

    Require RGBDS 0.9.3 for its DMG palette specs (pret#513)

commit 3f4b3ee
Author: Rangi42 <[email protected]>
Date:   Wed Jul 2 18:32:31 2025 -0400

    Check limits for warp, bg, and object events

commit aa85c00
Author: Rangi42 <[email protected]>
Date:   Wed Jul 2 17:25:03 2025 -0400

    Define `MAX_WARP_EVENTS`

commit 1e99747
Author: Rangi42 <[email protected]>
Date:   Mon Jun 30 13:42:56 2025 -0400

    Use more audio constants

commit 78e44a8
Author: Rangi42 <[email protected]>
Date:   Mon Jun 30 13:30:57 2025 -0400

    Use combined hardware constants

commit 56c405d
Author: Rangi <[email protected]>
Date:   Mon Jun 30 12:47:22 2025 -0400

    Replace hardware_constants.asm with hardware.inc (pret#511)

commit fcb61ae
Author: Rangi42 <[email protected]>
Date:   Wed Jun 25 23:59:47 2025 -0400

    Distinguish single trainer pics section from Pokemon pics

commit 5e5a498
Author: Rangi42 <[email protected]>
Date:   Wed Jun 25 11:27:38 2025 -0400

    Fishing graphics make more sense horizontally

commit 663b061
Author: Rangi42 <[email protected]>
Date:   Wed Jun 11 15:44:17 2025 -0400

    Simplify `li` macro
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rangi42 Rangi42 Rangi42 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Narishma-gb @Rangi42