Skip to content

Use SCREEN_WIDTH and remove obsolete comment #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 10, 2025
Merged

Use SCREEN_WIDTH and remove obsolete comment #531

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e631ee
Use SCREEN_WIDTH and remove obsolete comment
PokefanMarcel Sep 9, 2025
ad25331
Use SCREEN_WIDTH and rename loop in ClearScreenArea
PokefanMarcel Sep 9, 2025
52e1970
Use `SCREEN_HEIGHT` and `lb` in `CopyScreenTileBufferToVRAM`
PokefanMarcel Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions home/copy2.asm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,39 +161,39 @@ CopyVideoDataDouble::

ClearScreenArea::
; Clear tilemap area cxb at hl.
ld a, " " ; blank tile
ld de, 20 ; screen width
.y
ld a, " "
ld de, SCREEN_WIDTH
.loopRows
push hl
push bc
.x
.loopTiles
ld [hli], a
dec c
jr nz, .x
jr nz, .loopTiles
pop bc
pop hl
add hl, de
dec b
jr nz, .y
jr nz, .loopRows
ret

CopyScreenTileBufferToVRAM::
; Copy wTileMap to the BG Map starting at b * $100.
; This is done in thirds of 6 rows, so it takes 3 frames.

ld c, 6
ld c, SCREEN_HEIGHT / 3

ld hl, $600 * 0
lb hl, 0, 0
decoord 0, 6 * 0
call .setup
call DelayFrame

ld hl, $600 * 1
lb hl, SCREEN_HEIGHT / 3, 0
decoord 0, 6 * 1
call .setup
call DelayFrame

ld hl, $600 * 2
lb hl, 2 * SCREEN_HEIGHT / 3, 0
decoord 0, 6 * 2
call .setup
jp DelayFrame
Expand All @@ -215,7 +215,7 @@ CopyScreenTileBufferToVRAM::
ClearScreen::
; Clear wTileMap, then wait
; for the bg map to update.
ld bc, 20 * 18
ld bc, SCREEN_AREA
inc b
hlcoord 0, 0
ld a, " "
Expand Down