Use OBJ_SIZE and TILE_SIZE constants
#532
Open
+138
−121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rangi42
requested changes
Oct 19, 2025
Member
Rangi42
left a comment
Rangi42
left a comment
There was a problem hiding this comment.
Thanks for these improvements!
engine/battle/animations.asm
Outdated
| call FillMemory | ||
| pop hl | ||
| ld de, 7 * 3 * $10 + 4 * $10 + 4 | ||
| ld de, 7 * 3 tiles + 4 tiles + 4 |
Member
There was a problem hiding this comment.
Suggested change
| ld de, 7 * 3 tiles + 4 tiles + 4 | |
| ld de, (7 * 3 + 4) tiles + (1 tiles) / 4 |
engine/gfx/sprite_oam.asm
Outdated
| ld h, HIGH(wShadowOAM) | ||
| ld de, $4 | ||
| ld de, OBJ_SIZE | ||
| ld b, $a0 |
Member
There was a problem hiding this comment.
I think the $a0s here and below should be OAM_SIZE, and $90 should be OBJ_SIZE * (OAM_COUNT - 4).
Contributor
Author
There was a problem hiding this comment.
I used SCREEN_HEIGHT_PX + OAM_Y_OFS due to ld [hl], b below, and replaced $90 and $a0 with your suggestions.
Edit: what about LOW(wShadowOAMEnd), since the loop uses an address comparison to stop ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to continue replacing more hex number with constants:
OBJ_SIZEandTILE_SIZEfrom hardware.inc.SPRITESTATEDATA1_LENGTH,NUM_SPRITESTATEDATA_STRUCTSandTILE_1BPP_SIZEare used in some places.The changes below are also included:
OakSpeechwhere several direct MBC bank switches are requested. It's aimed to be added to bug documentation later.FillBgMapfunction to avoid a byte of dead codeSaveMainData