Skip to content

All 16 towns and cities updated for data name parity with pokeemerald. #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Feb 26, 2025
Merged

All 16 towns and cities updated for data name parity with pokeemerald. #875

merged 22 commits into from
Feb 26, 2025

Conversation

xyifer12
Copy link
Contributor

CHANGES: Names for EventScripts, FLAGs, Text have been modified to match those of PokeEmerald as closely as possible where applicable. New names have been created where needed.

Petalburg, Slateport, Mauville, Rustboro, Fortree, Lilycove, Mossdeep, Sootopolis, EverGrande, Littleroot, Oldale, Dewford, Lavaridge, Fallarbor, Verdanturf, Pacifidlog all modified.

Other text and script files have been modified where necessary for changes to be made in town and route files, this includes berries.inc and event_scripts.s for example.


TESTING DONE: "make [version] COMPARE=1" for ruby, ruby_rev1, ruby_rev2, ruby_debug, sapphire, sapphire_rev1, sapphire_rev2, sapphire_debug.
"make [version] COMPARE=1" for ruby_de, ruby_de_debug, sapphire_de, sapphire_de_debug as well.


NOTES: I've touched most but not all names. For some, I couldn't find or decide on accurate names. For others, I just didn't want to deal with the specific data. I've checked this in every version of the game multiple times, but it could really use another set of eyes looking for oversights and mistakes.

@GriffinRichards GriffinRichards merged commit 6ec9cc0 into pret:master Feb 26, 2025
1 check passed
@xyifer12 xyifer12 deleted the TownAndCityNameParityUpdate branch March 7, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants