-
Notifications
You must be signed in to change notification settings - Fork 235
All 16 towns and cities updated for data name parity with pokeemerald. #875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
GriffinRichards
merged 22 commits into
pret:master
from
xyifer12:TownAndCityNameParityUpdate
Feb 26, 2025
Merged
All 16 towns and cities updated for data name parity with pokeemerald. #875
GriffinRichards
merged 22 commits into
pret:master
from
xyifer12:TownAndCityNameParityUpdate
Feb 26, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dified MeteorFalls maps to use condensed script. Compare OK.
…eRivalFromOldale.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES: Names for EventScripts, FLAGs, Text have been modified to match those of PokeEmerald as closely as possible where applicable. New names have been created where needed.
Petalburg, Slateport, Mauville, Rustboro, Fortree, Lilycove, Mossdeep, Sootopolis, EverGrande, Littleroot, Oldale, Dewford, Lavaridge, Fallarbor, Verdanturf, Pacifidlog all modified.
Other text and script files have been modified where necessary for changes to be made in town and route files, this includes berries.inc and event_scripts.s for example.
TESTING DONE: "make [version] COMPARE=1" for ruby, ruby_rev1, ruby_rev2, ruby_debug, sapphire, sapphire_rev1, sapphire_rev2, sapphire_debug.
"make [version] COMPARE=1" for ruby_de, ruby_de_debug, sapphire_de, sapphire_de_debug as well.
NOTES: I've touched most but not all names. For some, I couldn't find or decide on accurate names. For others, I just didn't want to deal with the specific data. I've checked this in every version of the game multiple times, but it could really use another set of eyes looking for oversights and mistakes.