Town and City internal maps naming parity with PokeEmerald. Part 2 of 3. #878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hub.com/xyifer12/pokeruby into TownAndCityInternalMapsNamesUpdatePart2
…pting. _LotadAndSeedotHouse_ becomes _MonSizeRecordHouse_ instead.
…een named after Wallace.
…ectly matches Ruby.
…all known applicable cases.
…logue. Now uses a generic RockSmashHMMan name.
github-actions bot
pushed a commit
to GriffinRichards/pokeruby
that referenced
this pull request
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES: Names for EventScripts, FLAGs, and Text have been modified to mimic those of PokeEmerald. New names have been created where needed.
Mauville City, Mossdeep City, Oldale Town, Pacifidlog Town, Petalburg City, Rustboro City, Slateport City, Sootopolis City, Verdanturf Town have been targeted, changes made to ancillary files such as flags.h and event_scripts.s where applicable.
TESTING DONE: "[version] COMPARE=1" for ruby, ruby_rev1, ruby_rev2, ruby_debug, sapphire, sapphire_rev1, sapphire_rev2, sapphire_debug.
"[version] COMPARE=1" for ruby_de, ruby_de_debug, sapphire_de, sapphire_de_debug as well.
NOTES: With the majority of the work done, I can now turn my attention to contests and related miscellanea for part 3 of 3.