DEV -> MAIN [!! DO NOT MERGE !!] #43
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` jobs (angular#32497) The docs examples e2e tests have been quite flaky recently. This causes the `test_docs_examples` and `test_docs_examples_ivy` CircleCI jobs to often fail (and block PRs) without a real reason. This commit adds support for re-running failed docs examples e2e tests and configures the `test_docs_examples` and `test_docs_examples_ivy` jobs to try running each test that fails a second time, before giving up and marking it as failed. Closes angular#31841 Closes angular#31842 PR Close angular#32497
The intro paragraph currently uses the DI abbreviation, but it is clearer with DI written out and linked to the DI guide. PR Close angular#32400
… Pipelines (angular#32537) The commit range that is associated with a CI build is used for a couple of things (mostly related to payload-size tracking): - Determine whether a size change was caused by application code or dependencies (or both). - Add the messages of the commits associated with the build (and thus the payload-size change). NOTE: The commit range is only used on push builds. Previously, the commit range was computed based on the `CIRCLE_COMPARE_URL` environment variable. With [CircleCI Pipelines][1] enabled, `CIRCLE_COMPARE_URL` is no longer available and the commit range cannot be reliably detected. This commit switches `CI_COMMIT_RANGE` to only include the last commit. This can be less accurate in some rare cases, but is true in the majority of cases (on push builds). Additionally, it stores the CircleCI build URL in the database along with the payload data, so the relevant info can be retrieved when needed. [1]: https://circleci.com/docs/2.0/build-processing PR Close angular#32537
Properly Closed Bracket for the header PR Close angular#32552
…ges (angular#32577) The `aio/scripts/verify-codeownership.js` script (formerly `verify-docs-codeownership.js`) can be used to verify whether there are directories in the codebase that don't have a codeowner (in `.github/CODEOWNERS`) and vice versa. It does not aim to cover all files and directories, but do a coarse check on some important (or frequently changing) directories. Previously, the script only checked for API docs examples (in `packages/examples/`) and guides (and related images and example) (in `aio/content/`). This commit expands the script to also check for packages (i.e. top-level directories in `packages/`). It also renames the script from `verify-docs-codeownership.js` to `verify-codeownership.js`, to better reflect its new behavior. PR Close angular#32577
This commit expands the `lint` CircleCI job to also run the `tools/verify-codeownership.js` script. This script verifies that some important files/directories in the codebase have code-owners assigned in `.github/CODEOWNERS`. The main purpose of this change is to prevent adding new directories (e.g. packages or docs guides/examples) without assigning appropriate code-owners. When no code-owner is explicitly assigned, corresponding PRs will automatically request reviews from @IgorMinar, who is the "fall-back" code-owner. PR Close angular#32577
Previously, the docker images used on CI where specified by a tag (`10.16` and `10.16-browsers`). Since tags are not immutable, this only pins specific characteristics of the environment (e.g. the OS type and the Node.js version), but not others. Especially when using a tag that does not specify the patch version (e.g. `10.16` instead of `10.16.0`), it is inevitable that the image will change at some point, potentially leading to unrelated failures due to changes in the environment. One source of such failures can be the Chrome version used in tests. Since we install a specific ChromeDriver version (that is only compatible with specific Chrome version ranges), unexpectedly updating to a newer Chrome version may break the tests if the new version falls outside the range of supported version for our pinned ChromeDriver. Using a tag that specifies the patch version (e.g. `10.16.0`) or even the OS version (e.g. `10.16.0-buster`) is safer (i.e. has a lower probability of introducing the kind of breakages described above), but is still not fully hermetic. This commit prevents such breakages by pinning the docker images by ID. Image IDs are based on the image's digest (SHA256) and are thus immutable, ensuring that all CI jobs will be running on the exact same image. See [here][1] for more info on pre-built CircleCI docker images and more specifically [pinning images by ID][2]. [1]: https://circleci.com/docs/2.0/circleci-images [2]: https://circleci.com/docs/2.0/circleci-images#using-a-docker-image-id-to-pin-an-image-to-a-fixed-version PR Close angular#32602
With v544eb89198304846c8a9c488da6790a1672cac64 the CODEOWNERS file was amended to include an entry for the `localize` angular package. This package exists in master, but not in the `8.x` branch. This patch removes the entry from the file so that CI will work for `8.x`. PR Close angular#32618
This is a patch PR for angular#32479 This PR fixes a critical performance issue where the language service makes a MASSIVE number of filesystem calls when performing module resolution. This is because there is no caching. To make matters worse, module resolution is performed for every program change (which means every few keystrokes trigger a massive number of fs calls). PR Close angular#32483
) Ensures that the "core_all:size_test" target runs with "--define=compile=aot". This is necessary because we don't run this test on CI currently, but if we run it manually, we need to ensure that it runs with Ivy for proper size comparisons. PR Close angular#32613
…ular#32635) Updating [angular#8.2.x](https://github.com/angular/angular/tree/8.2.x) from [cli-builds#8.3.x](https://github.com/angular/cli-builds/tree/8.3.x). ## Relevant changes in [commit range](angular/cli-builds@6734efe...e21aeee): **Modified** - help/generate.json ## PR Close angular#32635
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!! DO NOT MERGE !!
Create this PR here for easier to check diff.