[DEV-19095] Newsroom payload change to include privacy and cookie policies #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuriyyakym
approved these changes
Jan 14, 2025
Comment on lines
+105
to
+111
| | { | ||
| link: string; | ||
| } | ||
| | { | ||
| content: string; | ||
| origin: 'default' | 'custom'; | ||
| }; |
There was a problem hiding this comment.
This could be extracted to a for example Policy or PolicySource type
There was a problem hiding this comment.
Ideal would be ContentOrigin, but it feels a bit dramatic for a very niche thing. I'll keep it as is for, and we'll address if this area grows.
pestaa
deleted the
feature/dev-19095-ui-to-enter-custom-policy-links-and-contents
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.