[DEV-19104] Feature - Tracking Consent #1207
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
yuriyyakym
force-pushed
the
feature/tracking-consent
branch
from
bd8f97f to
f737d7a
Compare
yuriyyakym
commented
Jan 24, 2025
Comment on lines
+21
to
+22
| import { CookieConsentProvider } from '@/modules/CookieConsent'; | ||
| import { CookieConsent } from '@/modules/CookieConsent/CookieConsent'; |
There was a problem hiding this comment.
It has to be separate. If I export CookieConsent from module root, I get this error:
which is caused by await app().newsroom() usage in CookieConsent component
pestaa
reviewed
Jan 27, 2025
Comment on lines
+34
to
+44
| <div className={styles.container}> | ||
| <IconBan className={styles.icon} /> | ||
| <div className={styles.title}>Content unavailable</div> | ||
| <p className={styles.description}> | ||
| <span>It seems this embed couldn't load due to your cookie preferences.</span> | ||
| <span>Please enable all cookies for a seamless experience.</span> | ||
| </p> | ||
| <Button onClick={updatePreferences} variation="secondary"> | ||
| Adjust cookie preferences | ||
| </Button> | ||
| </div> |
There was a problem hiding this comment.
It's going to be weird to have these English only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready, but blocked by prezly/theme-kit-js#843 and prezly/analytics#397