Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only apply header and footer preview parameters in preview mode #1211

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Only apply header and footer preview parameters in preview mode #1211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion modules/Footer/ui/Footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,10 @@ interface Props {

export function Footer({ children, ...props }: Props) {
const searchParams = useSearchParams();
const isPreviewMode = process.env.PREZLY_MODE === 'preview';

let { isWhiteLabeled } = props;
if (searchParams.has('is_white_labeled')) {
if (isPreviewMode && searchParams.has('is_white_labeled')) {
isWhiteLabeled = parseBoolean(searchParams.get('is_white_labeled'));
}

Expand Down
19 changes: 10 additions & 9 deletions modules/Header/ui/Header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ export function Header({
const [isSearchOpen, setSearchOpen] = useState(false);
const [measurement, headerRef] = useMeasure<HTMLElement>();
const isSearchPage = useBroadcastedPageTypeCheck('search');
const isPreviewMode = process.env.PREZLY_MODE === 'preview';

const shouldShowMenu =
categories.length > 0 || displayedLanguages > 0 || displayedGalleries > 0;
Expand Down Expand Up @@ -126,8 +127,8 @@ export function Header({
const newsroomName = information.name || newsroom.display_name;

const logo = useMemo(() => {
const newsroomLogoPreview = searchParams.get('main_logo');
if (newsroomLogoPreview !== null) {
const newsroomLogoPreview = isPreviewMode && searchParams.get('main_logo');
if (newsroomLogoPreview) {
try {
return JSON.parse(newsroomLogoPreview) as UploadedImage;
} catch {
Expand All @@ -136,15 +137,15 @@ export function Header({
}

return newsroom.newsroom_logo;
}, [newsroom.newsroom_logo, searchParams]);
}, [isPreviewMode, newsroom.newsroom_logo, searchParams]);

const logoSize = useMemo(() => {
const logoSizePreview = searchParams.get('logo_size');
const logoSizePreview = isPreviewMode && searchParams.get('logo_size');
return logoSizePreview || props.logoSize;
}, [props.logoSize, searchParams]);
}, [isPreviewMode, props.logoSize, searchParams]);

const mainSiteUrl = useMemo(() => {
const mainSiteUrlPreview = validateUrl(searchParams.get('main_site_url'));
const mainSiteUrlPreview = isPreviewMode && validateUrl(searchParams.get('main_site_url'));

if (mainSiteUrlPreview) {
return mainSiteUrlPreview;
Expand All @@ -155,16 +156,16 @@ export function Header({
}

return null;
}, [props.mainSiteUrl, searchParams]);
}, [isPreviewMode, props.mainSiteUrl, searchParams]);

const categoriesLayout = useMemo(() => {
const categoriesLayoutPreview = searchParams.get('categories_layout');
const categoriesLayoutPreview = isPreviewMode && searchParams.get('categories_layout');
if (categoriesLayoutPreview === 'dropdown' || categoriesLayoutPreview === 'bar') {
return categoriesLayoutPreview;
}

return props.categoriesLayout;
}, [props.categoriesLayout, searchParams]);
}, [isPreviewMode, props.categoriesLayout, searchParams]);

const isCategoriesLayoutBar = categoriesLayout === 'bar';
const isCategoriesLayoutDropdown = categoriesLayout === 'dropdown' || isMobile;
Expand Down
Loading