[DEV-19242] Feature - Sharing & Downloading #1212
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
yuriyyakym
force-pushed
the
feature/sharing-and-downloading
branch
from
59e3b0d to
4a19da8
Compare
yuriyyakym
force-pushed
the
feature/sharing-and-downloading
branch
from
8587d87 to
7d63878
Compare
- Refactoring - Nice output formatting - Extracting unnecessary code to be lazy loaded / called as an server function in order to reduce page load time
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| const clonedElement = element.cloneNode(true) as HTMLElement; | ||
|
|
||
| clonedElement.querySelectorAll('table').forEach((node) => { | ||
| node.outerHTML = `<div>${htmlTableToPlainText(node)}</div>`; |
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 3 days ago
To fix the problem, we need to ensure that any text content extracted from the DOM is properly escaped before being reinserted as HTML. This can be achieved by using a function that escapes HTML meta-characters, such as &, <, >, ", and '. We will create a utility function to perform this escaping and use it in the htmlTableToPlainText function.
- Create a utility function
escapeHtmlto escape HTML meta-characters. - Use the
escapeHtmlfunction to escape the content before inserting it into the<div>element in thehtmlTableToPlainTextfunction.
Suggested changeset
1
modules/Story/Share/utils/copyStoryText.ts
| @@ -4,2 +4,13 @@ | ||
|
|
||
| function escapeHtml(text: string): string { | ||
| const map: Record<string, string> = { | ||
| '&': '&', | ||
| '<': '<', | ||
| '>': '>', | ||
| '"': '"', | ||
| "'": ''', | ||
| }; | ||
| return text.replace(/[&<>"']/g, function(m) { return map[m]; }); | ||
| } | ||
|
|
||
| type TagName = string; | ||
| @@ -48,3 +59,3 @@ | ||
| clonedElement.querySelectorAll('table').forEach((node) => { | ||
| node.outerHTML = `<div>${htmlTableToPlainText(node)}</div>`; | ||
| node.outerHTML = `<div>${escapeHtml(htmlTableToPlainText(node))}</div>`; | ||
| }); |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.