Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prose list style image fix #457

Merged
merged 15 commits into from
Oct 23, 2023
Merged

Prose list style image fix #457

merged 15 commits into from
Oct 23, 2023

Conversation

joseph-lozano
Copy link
Contributor

@joseph-lozano joseph-lozano commented Oct 10, 2023

Summary

Fixes #455

Namely, in dark mode. Prose unordered list elements will have a white dash instead of a black one.

List of notable changes:

Prose's un-ordered list style now works nicely in dark mode

What should reviewers focus on?

  • Check dark and light colors.

Steps to test:

  1. You can view the prose in a dark theme under the components-prose--unordered-list story

Supporting resources (related issues, external links, etc):

Contributor checklist:

  • All new and existing CI checks pass
  • Tests prove that the feature works and covers both happy and unhappy paths
  • Any drop in coverage, breaking changes or regressions have been documented above
  • New visual snapshots have been generated / updated for any UI changes
  • All developer debugging and non-functional logging has been removed
  • Related issues have been referenced in the PR description

Reviewer checklist:

  • Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
  • Check that tests prove the feature works and covers both happy and unhappy paths
  • Check that there aren't other open Pull Requests for the same update/change

Screenshots:

Please try to provide before and after screenshots or videos

Before After

CleanShot 2023-10-16 at 09 07 21@2x

CleanShot 2023-10-16 at 09 08 27@2x

@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2023

🦋 Changeset detected

Latest commit: 97561ee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@primer/brand-primitives Patch
@primer/react-brand Patch
@primer/brand-e2e Patch
@primer/brand-fonts Patch
@primer/brand-config Patch
@primer/brand-storybook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2023

🟢 No design token changes found

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2023

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

@joseph-lozano joseph-lozano temporarily deployed to github-pages October 10, 2023 13:58 — with GitHub Actions Inactive
@joseph-lozano joseph-lozano temporarily deployed to github-pages October 10, 2023 14:41 — with GitHub Actions Inactive
@joseph-lozano joseph-lozano marked this pull request as ready for review October 13, 2023 14:23
@joseph-lozano joseph-lozano changed the title WIP: Prose list style image fix Prose list style image fix Oct 16, 2023
@joseph-lozano joseph-lozano temporarily deployed to github-pages October 16, 2023 12:54 — with GitHub Actions Inactive
@joseph-lozano joseph-lozano temporarily deployed to github-pages October 16, 2023 13:40 — with GitHub Actions Inactive
@joseph-lozano joseph-lozano temporarily deployed to github-pages October 16, 2023 17:31 — with GitHub Actions Inactive
Copy link
Contributor

@nsolerieu nsolerieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DIF and preview looks good to me ✌️

@joseph-lozano joseph-lozano merged commit 9ea0803 into main Oct 23, 2023
14 checks passed
@joseph-lozano joseph-lozano deleted the prose-listStyleImage-fix branch October 23, 2023 13:48
@primer-css primer-css mentioned this pull request Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - Prose's unordered lists do not play well with dark mode
3 participants