-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prose list style image fix #457
Conversation
🦋 Changeset detectedLatest commit: 97561ee The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
20a1669
to
f903876
Compare
🟢 No design token changes found |
🟢 No visual differences foundOur visual comparison tests did not find any differences in the UI. |
packages/design-tokens/src/tokens/functional/components/prose/colors.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DIF and preview looks good to me ✌️
Summary
Fixes #455
Namely, in dark mode. Prose unordered list elements will have a
white
dash instead of a black one.List of notable changes:
Prose's un-ordered list style now works nicely in dark mode
What should reviewers focus on?
Steps to test:
components-prose--unordered-list
storySupporting resources (related issues, external links, etc):
Contributor checklist:
Reviewer checklist:
Screenshots: